Re: Installer, ISO9660, etc.

[Danny Milosavljevic]

Hi Ludo,

On Fri, 07 Jul 2017 13:34:52 +0200
address@hidden (Ludovic Courtès) wrote:

> Danny Milosavljevic <address@hidden> skribis:
> 
> > 95% done.  If would actually work if we came to a consensus about the 
> > volume label (it must be uppercase; see bug# 27520 in guix-patches).  Also, 
> > UUID boot support is still mostly missing - same as in the non-iso9660 
> > case.  

>I hope I’m not holding anything back in this area!

Oh, not at all.  I'm just not clear on which way we chose (if any?).

What was the string-upcase solution?  Even if it's created with (string-upcase 
"GuixSD") (and it is - if you don't override it) the boot code as it is now 
will still fail to find the root - because it matches labels case-sensitively.  
The string-upcase is buried deep within the image creation procedure.

Or do you mean I should put (string-upcase "GuixSD") in system-disk-image in 
gnu/system/vm.scm as well ? That would work, I guess... although the finished 
image (iso9660 or not!) would still have "GUIXSD" then.  I don't see that as a 
big deal, though :)

There's still the following places:

./gnu/build/vm.scm:                    search --set=root --label 
gnu-disk-image~@
./gnu/system/install.scm:              (device "gnu-disk-image")
./gnu/system/vm.scm:    "gnu-disk-image")

Or do you mean we should just match case-insensitively in 
gnu/build/file-systems.scm ?

I.e. use

 (define partition-label-predicate
  (partition-predicate read-partition-label string-ci=?))

That would mean match case-insensitively for both iso9660 and non-iso9660.  I 
would very much prefer this fix.

Whatever it is, we should just pick a way, any way :)

Now Hydra is building a 1 GB iso9660 image that won't boot.

I've pushed bug# 27521 so "iso9660-image" will now heed the root-label (from 
system-disk-image) just like the other filesystems do - and then uppercase it.  
That finishes the creation part.  Now the booting part... how? :)