Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3

[Huang\, Ying]

Hi, Ricardo,

Ricardo Wurmus <address@hidden> writes:

> address@hidden writes:
>
>> From: Huang Ying <address@hidden>
>>
>> Gtk+3 now have multiple outputs, so the gtk-query-immodules-3.0 should be 
>> find
>> in bin output.
>
> Ah, I was wondering why this broke!  Thanks for investigating it.
>
>> The fix works, but appears hacky, because I haven't read much guix source
>> code, so I don't know the best solution.
>
> It’s only hacky because I tried to reuse the code for both versions of
> Gtk.  Maybe “gtk+-2” should also get a “bin” output…?

That sounds reasonable for me.

> This is acceptable with the changes Danny suggested.  Maybe we can find
> a way to make this prettier in the future.

I have sent out -v3 which addressed Danny's comments with the following
subject,

[PATCH -v3] Fix gtk-im-modules for gtk+3

> Thanks again for taking the time to investigate and fix it, and to
> submit a patch!  I’m very grateful for this contribution.

You are welcome!

Best Regards,
Huang, Ying

> --
> Ricardo
>
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net