Re: [PATCH] gnu: Add freeciv.

[ng0]

Arun Isaac writes:

> * gnu/packages/games.scm (freeciv): New variable.

Nice :)

> ---
>  gnu/packages/games.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 0edd585fa..81588aabb 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -104,6 +104,7 @@
>    #:use-module (gnu packages xdisorg)
>    #:use-module (gnu packages tls)
>    #:use-module (gnu packages pcre)
> +  #:use-module (gnu packages cyrus-sasl)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system haskell)
>    #:use-module (guix build-system python)
> @@ -3071,3 +3072,33 @@ symbols, the game needs graphics to render the 
> non-euclidean world.")
>  for Un*x systems with X11.")
>      (home-page "http://olofson.net/kobodl/";)
>      (license license:gpl2+)))
> +
> +(define-public freeciv
> +  (package
> +   (name "freeciv")
> +   (version "2.5.6")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri (string-append
> +           "http://download.gna.org/freeciv/stable/freeciv-";
> +           version ".tar.bz2"))

I'd write it like this:
(uri (string-append "http://download.gna.org/freeciv/";
                    "stable/freeciv-" version ".tar.bz2"))

but that's just cosmetic.

> +     (sha256
> +      (base32
> +       "16wrnsx5rmbz6rjs03bhy0vn20i6n6g73lx7fjpai98ixhzc5bfg"))))
> +   (build-system gnu-build-system)
> +   (inputs
> +    `(("curl" ,curl)
> +      ("cyrus-sasl" ,cyrus-sasl)
> +      ("gtk+" ,gtk+)
> +      ("sdl-mixer" ,sdl-mixer)
> +      ("zlib" ,zlib)))
> +   (native-inputs
> +    `(("pkg-config" ,pkg-config)))
> +   (home-page "http://www.freeciv.org/";)
> +   (synopsis "Turn based empire building strategy game")
> +   (description "Freeciv is a turn based empire building strategy game
> +inspired by the history of human civilization.  The game commences in
> +prehistory and your mission is to lead your tribe from the Stone Age
> +to the Space Age.")
> +   (license license:gpl2+)))

The rest looks good to me.
I don't really played very long, but the game doesn't segfault,
so I suppose it works as intended.
-- 
ng0 . https://www.inventati.org/patternsinthechaos/