Re: [PATCH v2 1/2] gnu: Add dub.

[Pjotr Prins]

Great work!

On Mon, Jan 23, 2017 at 11:46:25PM +0100, Ludovic Courtès wrote:
> Danny Milosavljevic <address@hidden> skribis:
> 
> > * gnu/packages/ldc.scm (dub): New variable.
> 
> [...]
> 
> > +       (modify-phases %standard-phases
> > +         (delete 'configure)
> > +         (replace 'build
> > +           (lambda _
> > +             (zero? (system* "./build.sh"))))
> > +         (replace 'install
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (let* ((out (assoc-ref outputs "out"))
> > +                    (outbin (string-append out "/bin")))
> > +               (mkdir-p outbin)
> > +               (install-file "bin/dub" outbin)))))))
> 
> Please add #t at the end of this lambda, to denote success.
> 
> Otherwise LGTM, thanks!
> 
> Ludo’.
> 

--