[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add python-pyodbc-c.
From: |
Marius Bakke |
Subject: |
Re: [PATCH] gnu: Add python-pyodbc-c. |
Date: |
Thu, 26 Jan 2017 19:14:41 +0100 |
User-agent: |
Notmuch/0.23.5 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) |
ng0 <address@hidden> writes:
> Danny Milosavljevic <address@hidden> writes:
>
>> * gnu/packages/databases.scm (python-pyodbc-c, python2-pyodbc-c):
>> New variables.
[...]
>> + (file-name (string-append name "-" version ".tar.gz"))))
>> + (build-system python-build-system)
>> + (inputs
>> + `(("unixodbc" ,unixodbc)))
>> + (arguments
>> + `(#:tests? #f ; no tests exist
>> + ))
Please move these to the previous line.
>> + (home-page "https://github.com/mkleehammer/pyodbc")
>
> This is pulled from gitlab and the homepage is on gitlab? I think
> it's better to use the gitlab repository as home-page then, or
> what's the reason?
I think this is a better home page since it provides usage instructions:
https://mkleehammer.github.io/pyodbc/
>
>> + (synopsis "Python ODBC Library")
>> + (description "This package provides a Python DB-API driver for ODBC.")
>
> If I remember correctly, we should avoid starting synopsis and
> description with words like "This". What about:
>
> (description "@code{python-pyodbc-c} provides …"
Either of these two styles are fine IMO. LGTM!
signature.asc
Description: PGP signature