Re: [PATCH 0/1] Help wanted fixing a ruby-minitar bug

[Ben Woodcroft]

Hi Leo,


On 25/01/17 07:40, Ludovic Courtès wrote:
> Leo Famulari <address@hidden> skribis:
>
> > I tried using this patch to fix a bug in ruby-minitar, but the build
> > fails as shown below. Any ideas?
> >
> > $ ./pre-inst-env guix build ruby-minitar
> > The following derivations will be built:
> >     /gnu/store/naprvm320mvzlhv4ciax0436qqm3r8zj-ruby-minitar-0.5.4.drv
> >     /gnu/store/vz70g01wln7aflljz65yf425pppcgpjd-minitar-0.5.4.tar.xz.drv
> > @ build-started 
> > /gnu/store/vz70g01wln7aflljz65yf425pppcgpjd-minitar-0.5.4.tar.xz.drv - 
> > x86_64-linux 
> > /var/log/guix/drvs/vz//70g01wln7aflljz65yf425pppcgpjd-minitar-0.5.4.tar.xz.drv.bz2
> > data.tar.gz
> > metadata.gz
> > source is under 'data.tar.gz'
> [...]
>
> >     ?: 0 [chdir "data.tar.gz"]
> This is apparently a “tarbomb”: it unpacks more than one file in $PWD.
> The ‘first-subdirectory’ procedure in gnu-build-system.scm is a bit
> stupid and takes the first file in $PWD as the directory to cd to.

Well, it is unpacking a .gem file rather than a tar.gz, and patching 
rubygem sources has never worked. It might be worth fixing this in 
general, or perhaps packaging minitar from GitHub rather than rubygems.

As usual, thanks for keeping on top of all this.
ben