Re: [PATCH 4/6] gnu: Add rocksdb.

[Ludovic Courtès]

Marius Bakke <address@hidden> skribis:

> * gnu/packages/databases.scm (rocksdb): New variable.

[...]

> +           (lambda* (#:key (make-flags '()) #:allow-other-keys)
> +             ;; Prevent the build from adding machine-specific optimizations.
> +             ;; This does not work if passed as a make flag...
> +             (setenv "PORTABLE" "1")
> +             (and (zero? (apply system* "make" "static_lib" make-flags))
> +                  (zero? (apply system* "make" "shared_lib" make-flags)))))

We could avoid building the static libs if nothing requires it; no
strong opinion though.

> +    (home-page "http://rocksdb.org/";)
> +    (synopsis "Persistent key-value store for fast storage")
> +    (description
> +     "RocksDB is an embeddable, persistent key-value storage library that is
> +designed for flash and RAM storage.")

Could you expound a little bit?

LGTM!

Ludo’.