guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add wwwoffle.


From: Marius Bakke
Subject: Re: [PATCH] gnu: Add wwwoffle.
Date: Thu, 22 Dec 2016 16:58:16 +0100
User-agent: Notmuch/0.23.3 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu)

Bake Timmons <address@hidden> writes:

> * gnu/packages/web.scm (wwwoffle): New variable.
> ---
>  gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)

Thanks for this! The patch looks good, but does not build on master
because the "libgcrypt" variable cannot be found. It can be imported
from the "gnupg" module.

Some other trivial comments: Home page and source should use HTTPS when
available, and we try to add comments about why tests are disabled.
Could you also add a copyright line for yourself?

I can do these minor edits for you if you prefer, but would like to
confirm name and email for the copyright. Thanks!

>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 184869200..c4e716c2b 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -668,6 +668,34 @@ server).  It was primarily designed to be used by one 
> person or a small group
>  of people.")
>      (license l:expat)))
>  
> +(define-public wwwoffle
> +  (package
> +    (name "wwwoffle")
> +    (version "2.9j")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://www.gedanken.org.uk/software/";
> +                                  "wwwoffle/download/wwwoffle-"
> +                                  version ".tgz"))
> +              (sha256
> +               (base32
> +                "1ihil1xq9dp21hf108khxbw6f3baq0w5c0j3af038y6lkmad4vdi"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags '("--with-gnutls")
> +       #:tests? #f))
> +    (native-inputs `(("flex" ,flex)))
> +    (inputs `(("gnutls" ,gnutls)
> +              ("libcrypt", libgcrypt)))
> +    (home-page "http://www.gedanken.org.uk/software/wwwoffle/";)
> +    (synopsis "Caching web proxy optimized for intermittent internet links")
> +    (description "WWWOFFLE is a proxy web server that is especially good for
> +intermittent internet links.  It can cache HTTP, HTTPS, FTP, and finger
> +protocols, and supports browsing and requesting pages while offline, 
> indexing,
> +modifying pages and incoming and outgoing headers, monitoring pages for
> +changes, and much more.")
> +    (license l:gpl2+)))
> +
>  (define-public libyaml
>    (package
>      (name "libyaml")
> -- 
> 2.11.0

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]