Re: [PATCH 6/6] gnu: Add grub-efi.

[Ludovic Courtès]

Hi Marius,

Marius Bakke <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:
>
>>>>> From 940c03c7dcddec019e27f6eb1470aeab4db57799 Mon Sep 17 00:00:00 2001
>>>>> From: Marius Bakke <address@hidden>
>>>>> Date: Thu, 20 Oct 2016 17:26:52 +0100
>>>>> Subject: [PATCH] gnu: Add grub-efi.
>>>>>
>>>>> * gnu/packages/grub.scm (grub-efi): New variable.
>>>>
>>>> [...]
>>>>
>>>>> +    (name "grub-efi")
>>>>> +    (synopsis (string-append (package-synopsis grub) " (UEFI version)"))
>>>>
>>>> Please use a literal string for ‘synopsis’; use of ‘string-append’ like
>>>> this prevents i18n.
>>>>
>>>>> +     `(#:tests? #f ; FIXME: 40 failures, 24 skipped, 17 passed.
>>>>
>>>> It would be good to investigate, especially if the tests pass in the
>>>> ‘grub’ package.
>>>>
>>>> Also, what’s the rationale for making ‘grub-efi’ separate instead of
>>>> incorporating the changes in ‘grub’ proper?  Are there issues around the
>>>> portability of ‘efibootmgr’, or an increased closure size?
>>>
>>> This is a good point. The only difference with "--with-platform=efi" is
>>> that another directory is created in place of the i386-pc directory. It
>>> is perfectly possible to build multiple platforms and copying the
>>> platform-specific stuff to $out/lib -- grub will pick the correct
>>> platform at runtime. This is what the Gentoo ebuild does.
>>
>> Are you saying that a GRUB compiled with UEFI support will no longer
>> work out-of-the-box on non-UEFI machines, unless platform-specific stuff
>> is moved like you suggest?
>
> Ha, no, it was just a long-winded and intoxicated way of saying what you
> proposed should work fine. :)

It turns out I have an immediate need ;-), so I pushed this as commit
3eee16130d858ae96510ec1c7d38d31290de2699.  Let me know if that doesn’t
seem right!

Now there are things I didn’t quite get.  Apparently you’re supposed to
have a /boot/efi as a vfat partition, and ‘grub-install’ is supposed to
detect it and install the EFI stuff, or so I thought (info "(grub)
Installing GRUB using grub-install").

However, ‘grub-install’ still seems to be installing for “i386-pc”
instead of EFI.

What am I missing?

Thanks!

Ludo’.