Re: [PATCH] Add php

[Ludovic Courtès]

Hi Marius,

Marius Bakke <address@hidden> skribis:

> Marius Bakke <address@hidden> writes:
>
>> Julien Lepiller <address@hidden> writes:
>>
>>>> Could you send an updated patch to address those issues?  Then we can
>>>> happily apply it.
>>> here is the updated patch. I let the tests be done because it doesn't
>>> harm, but it does no good either, so feel free to disable them if you
>>> prefer.
>>
>> Hello! I've gone through this package and made some improvements. I also
>> managed to enable the test suite, but had to resort to strace to figure
>> out what was going on (/bin/sh calls..).
>
> Oops, here is a version that actually passes `guix lint`.
>
> From 83b2913549784e5d3bafd29641e314b308f7df11 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <address@hidden>
> Date: Fri, 11 Nov 2016 15:18:29 +0100
> Subject: [PATCH] gnu: Add php.
>
> * gnu/packages/php.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

Thanks for the update!

> +                            ;;"bcmath/libbcmath"

So this one is very different from ‘bc’?

> +                            ;;"fileinfo/libmagic" ; This is a patched 
> version of libmagic.

Here adding a dependency on ‘file’ instead (the package that provides
libmagic) didn’t cut it, right?

> +         (add-before 'check 'set-test-environment
> +           (lambda _
> +             ;; Without this variable, `make test' passes regardless of 
> failures.
> +             (setenv "REPORT_EXIT_STATUS" "1")
> +             #t)))
> +       #:test-target "test"
> +       #:tests? #t))

Do you have more info as to what fails?  I wouldn’t be surprised if
there were lots of issues having to do with the use of /bin/sh, host
name lookups, and other things not available in the build environment.

Could you gather more info as to what fails so that we can either fix
it, or at least convince ourselves that these are not serious issues and
document them in a comment?

Thanks Julien & Marius!

Ludo’.