[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add Handbrake.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: Add Handbrake. |
Date: |
Sat, 12 Nov 2016 12:37:00 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Bavier <address@hidden> skribis:
> On Mon, 31 Oct 2016 10:30:40 +0100
> Ricardo Wurmus <address@hidden> wrote:
>
>> Eric Bavier <address@hidden> writes:
>>
>> > * gnu/packages/video.scm (handbrake): New variable.
>> > * gnu/packages/patches/handbrake-pkg-config-path.patch: New patch.
>> > * gnu/local.mk (dist_patch_DATA): Add it.
>>
>> Yay, thanks for the patch!
>
> Thanks for the feedback! I've incorporated your and Efraim's
> suggestions in the attached patch.
>
> The resulting Handbrake mostly works, but the default transcoding
> presets and gui icons are missing. I've done as much as I can to debug
> this, but I can't put any more time into it. I could commit this
> as-is and fix it later, or someone else could pick it up.
There are other packages with missing icons, I think this can be fixed
separately.
So I’d say you can commit it.
Thank you,
Ludo’.