guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/6] gnu: Add python-orderedmultidict.


From: Hartmut Goebel
Subject: Re: [PATCH 3/6] gnu: Add python-orderedmultidict.
Date: Thu, 3 Nov 2016 22:58:27 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

Am 03.11.2016 um 11:56 schrieb Danny Milosavljevic:
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-tests
> +           (lambda _
> +             (and (zero? (system* "touch" "tests/__init__.py"))))))))

Maybe add a note like: "The packages uses nosetest for running the
tests. Adding this initfile allows to run the test suite without
requiring nosetest."

> +    (synopsis "Python Ordered Multivalue Dictionary - omdict.")
Trailing period
> +    (description "This package contains Ordered Multivalue Dictionary - 
> omdict
> +- for Python.")

Please be more verbose here. Maybe the description could be enhanced
using text from the setup.py:

    A multivalue dictionary is a dictionary that can store multiple
    values for the
    same key. An ordered multivalue dictionary is a multivalue
    dictionary that
    retains the order of insertions and deletions.


-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | address@hidden               |
| www.crazy-compilers.com | compilers which you thought are impossible |





reply via email to

[Prev in Thread] Current Thread [Next in Thread]