Re: [PATCH 01/10] * gnu/system.scm (<boot-parameters>): Add 'store-device' and 'store-fs-mount-point'.

[Ludovic Courtès]

Chris Marusich <address@hidden> skribis:

> address@hidden (Ludovic Courtès) writes:

>> However, after rereading the whole series, I think what we need is a
>> ‘device-mount-point’ in <menu-entry>, in a symmetrical fashion.
>
> That would work, and I'm open to it.  However, before we decide to do
> that, what do you think about the alternative in which we simply require
> that all the paths in the <boot-parameters> and <menu-entry> objects
> must be relative paths?  By relative, I mean relative to the GRUB root.
> If all the paths were relative, then we would not need a
> 'device-mount-point' field in the first place.
>
> However, I suspect it might be tricky to get all the information we need
> if we do it that way.  For example, during switch-generation, how would
> we know the correct paths to use for the files in the GRUB
> configuration's 'eye-candy' section?  In light of that, I suspect it
> would be better to do what you've suggested: include the mount point in
> both <boot-parameters> and <menu-entry>.

Yeah, I’m not sure we could easily manage to have only relative file
names because most of them are computed when the derivations get built
(that’s why ‘strip-mount-point’ currently has to return a gexp instead
of stripping the mount point directly.)

>> Attached is an updated patch.  I have grouped together the patches of
>> your series that touch this topic, including the documentation part
>> (this is all one logical change so it’s best to commit it as such), and
>> made the above change.
>
> Thank you for doing this.  I've looked it over.  It looks good to me.
> Unless you think strongly that we should use relative paths in the
> <boot-parameters> and <menu-entry> objects, I think it's good as-is!

Good!

>> If that’s fine with you, I’d like to commit this version.  With that
>> done, the rest of the patch series will be rather easy.
>>
>> WDYT?
>>
>
> Sounds good to me.

Pushed as 1ef8b72a7f87afe7cffe52393d99e1b14e4770e1!

> Unless you think strongly that we should use relative paths in the
> <boot-parameters> and <menu-entry> objects, I will re-submit my
> patches once you have committed this change to the official repo.

That would be awesome.

Thanks again for all your work and patience!

Ludo’.