[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] gnu: Add openocd.
From: |
David Craven |
Subject: |
Re: [PATCH 3/3] gnu: Add openocd. |
Date: |
Wed, 26 Oct 2016 14:49:00 +0200 |
Hi Theodoros,
Do we really need this patch? Is there a reason why it hasn't been
upstreamed yet?
(add-before 'configure 'bootstrap
+ (lambda _
+ (system* "aclocal")
+ (system* "libtoolize" "--automake" "--copy")
+ (system* "autoconf")
+ (system* "autoheader")
+ (system* "automake" "--gnu" "--add-missing" "--copy")
+ #t))
Why not (add-before 'configure 'autoreconf
(lambda _
(zero? (system* "autoreconf" "-vfi"))
I prefer indenting like this as is done in most of the codebase:
+ (inputs
`(("libusb" ,libusb)
+ ("libusb-compat" ,libusb-compat)
+ ("libftdi" ,libftdi)
+ ("hidapi" ,hidapi)))
+ (native-inputs
`(("autoconf" ,autoconf)
+ ("libtool" ,libtool)
+ ("automake" ,automake)
+ ("pkg-config" ,pkg-config)))
It would also be nice if the inputs where ordered alphabetically.
Thanks for the patch, looking good!! You don't need to resubmit
(unless someone else has more objections :).
David
- [PATCH 0/3] gnu: Add gdb-arm-none-eabi and openocd., Theodoros Foradis, 2016/10/25
- [PATCH 3/3] gnu: Add openocd., Theodoros Foradis, 2016/10/25
- Re: [PATCH 3/3] gnu: Add openocd.,
David Craven <=
- [PATCH v2 0/3] gnu: Add gdb-arm-none-eabi and openocd., Theodoros Foradis, 2016/10/26
- [PATCH v2 1/3] gnu: Add gdb-arm-none-eabi., Theodoros Foradis, 2016/10/26
- [PATCH v2 2/3] gnu: Add hidapi., Theodoros Foradis, 2016/10/26
- Re: [PATCH v2 2/3] gnu: Add hidapi., Ricardo Wurmus, 2016/10/28
- Re: [PATCH v2 2/3] gnu: Add hidapi., Theodoros Foradis, 2016/10/28
- [PATCH v2 3/3] gnu: Add openocd., Theodoros Foradis, 2016/10/26
- Re: [PATCH v2 3/3] gnu: Add openocd., Efraim Flashner, 2016/10/27
- Re: [PATCH v2 3/3] gnu: Add openocd., Ricardo Wurmus, 2016/10/28
- Re: [PATCH v2 3/3] gnu: Add openocd., Theodoros Foradis, 2016/10/28
- [PATCH v3 1/3] gnu: Add gdb-arm-none-eabi., Theodoros Foradis, 2016/10/28