[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] gnu: xapian: Use 'modify-phases'.
|
From: |
Leo Famulari |
|
Subject: |
Re: [PATCH 3/4] gnu: xapian: Use 'modify-phases'. |
|
Date: |
Mon, 17 Oct 2016 14:00:15 -0400 |
|
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Mon, Oct 17, 2016 at 05:55:05PM +0100, Marius Bakke wrote:
> * gnu/packages/search.scm (xapian)[arguments]: Use 'modify-phases'.
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch-remotetcp-harness
> + (lambda _
> + (substitute* "tests/harness/backendmanager_remotetcp.cc"
> + (("/bin/sh") (which "bash"))))))))
Please change it to use (which "sh") instead. Bash changes its behavior
based on whether it is called as `bash` or `sh` (see Invocation in
bash(1)).
Otherwise LGTM.