[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 07/07: guix: python-build-system: Fix an outdated comment.
From: |
Mark H Weaver |
Subject: |
Re: 07/07: guix: python-build-system: Fix an outdated comment. |
Date: |
Thu, 13 Oct 2016 15:32:09 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
address@hidden (Hartmut Goebel) writes:
> htgoebel pushed a commit to branch master
> in repository guix.
>
> commit 635a7af45d6e2105ad65d1a9531126cc232a2a50
> Author: Hartmut Goebel <address@hidden>
> Date: Sun Oct 2 18:48:56 2016 +0200
>
> guix: python-build-system: Fix an outdated comment.
>
> The python-build-system uses phases the build and install, but not
> configure. So the old comment was plain wrong since Sept. 2013, when the
> build
> phase has been added.
> ---
> guix/build/python-build-system.scm | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/guix/build/python-build-system.scm
> b/guix/build/python-build-system.scm
> index 9109fb4..e906e60 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -137,8 +137,7 @@ installed with setuptools."
> #t))
>
> (define %standard-phases
> - ;; 'configure' and 'build' phases are not needed. Everything is done
> during
> - ;; 'install'.
> + ;; 'configure' phase is not needed.
> (modify-phases gnu:%standard-phases
> (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-1980)
> (delete 'configure)
This change triggered over 6300 rebuilds on 'master'. I reverted it.
Please beware that changing some files in guix/build/*.scm can trigger a
large number of rebuilds, because some of these files are implicitly
used as inputs to a large number of builds.
Regards,
Mark
- Re: 07/07: guix: python-build-system: Fix an outdated comment.,
Mark H Weaver <=