Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.

[Ivan Vilata i Balaguer]

Leo Famulari (2016-09-16 01:46:37 -0400) wrote:

> On Wed, Sep 14, 2016 at 11:17:24AM +0200, Ivan Vilata i Balaguer wrote:
> > Subject: [PATCH 2/2] gnu: python: Add i3-quickswitch.
> > 
> > * gnu/packages/python.scm (i3-quickswitch): New variable.
> 
> Cool, this works :)
> 
> > +(define-public i3-quickswitch
> > +  (package
> > +    (name "i3-quickswitch")
> 
> Again, I think that we should stay closer to the upstream name, in this
> case "quickswitch-for-i3".
> 
> > +    (build-system python-build-system)
> 
> Also again, it would be nice to include README.rst.

Thanks Leo and Brendan for your comments, I'm writing new versions of
the packages following your suggestions, unfortunately I found out that
``quickswitch.py`` makes use of the Debian-specific ``which`` tool, so
I'm also working on including a small patch (which I've also
[reported][1] for completeness).  More things to learn!`;)`

[1]: https://github.com/proxypoke/quickswitch-for-i3/pull/28

-- 
Ivan Vilata i Balaguer -- https://elvil.net/