Re: [PATCH] gnu: tbb: Update to 2017_20160722.

[Eric Bavier]

On 2016-09-09 04:51, ng0 wrote:
> * gnu/packages/tbb.scm (tbb): Update to 2017_20160722.
> ---
>  gnu/packages/tbb.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/tbb.scm b/gnu/packages/tbb.scm
> index 0e9db72..22ce068 100644
> --- a/gnu/packages/tbb.scm
> +++ b/gnu/packages/tbb.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2015 Ricardo Wurmus <address@hidden>
> +;;; Copyright © 2016 ng0 <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -27,16 +28,16 @@
>  (define-public tbb
>    (package
>      (name "tbb")
> -    (version "4.3.2")
> +    (version "2017_20160722")

I think we should go with "2017" as the version; it seems to be what's 
advertised.  This is their first release with the year-as-version, so we 
don't know how they'd like to denote patch versions.

>      (source (origin
>                (method url-fetch)
>                (uri (string-append
>                      
> "https://www.threadingbuildingblocks.org/sites/default";
>                      "/files/software_releases/source/"
> -                    "tbb43_20141204oss_src.tgz"))
> +                    "tbb" version "oss_src.tgz"))
>                (sha256
>                 (base32
> -                
> "0jsczl99jfgj47kj7c4sd4fk7v3rbaiax1ng9ypykz1hh0lrrsws"))
> +                
> "038rmv3s8si51bjrzwyv8ldqw742fjjdfayi8pmjaq5zw32b8pzx"))
>                (modules '((guix build utils)))
>                (snippet
>                 '(substitute* "build/common.inc"

The 2017 version also brings with it a change in license from GPLv2 with 
libstdc++ runtime exception to the ASL2.0.  Could you include that in 
this patch too?

Thanks,
--
`~Eric