[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add git-review.
From: |
Efraim Flashner |
Subject: |
Re: [PATCH] gnu: Add git-review. |
Date: |
Thu, 8 Sep 2016 20:58:01 +0300 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Thu, Sep 08, 2016 at 10:28:37PM +1000, Ben Woodcroft wrote:
> Hi there, thanks for the patch. I do not have any experience with Gerrit but
> some comments below:
>
>
> On 08/09/16 17:06, Clément Lassieur wrote:
> > [..]
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (string-append
> > +
> > "https://pypi.python.org/packages/source/g/git-review/git-review-"
> > + version ".tar.gz"))
>
> Rather: (uri (pypi-uri "git-review" version))
>
> > + (sha256
> > + (base32
> > + "07d1jn9ryff5j5ic6qj5pbk10m1ccmpllj0wyalrcms1q9yhlzh8"))))
> > + (build-system python-build-system)
> > + (arguments `(#:tests? #f)) ; tests require a running Gerrit server
> > + (native-inputs
> > + `(("python-pbr" ,python-pbr)))
> > + (inputs
> > + `(("python-requests" ,python-requests)
> > + ("git" ,git)))
>
> I think including git simply as an input is problematic because git-review
> calls git via 'subprocess', as evidenced by
>
> $ ./pre-inst-env guix environment -C --ad-hoc git-review
> $ git-review
> [..]
> File
> "/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3/lib/python3.4/subprocess.py",
> line 1457, in _execute_child
> raise child_exception_type(errno_num, err_msg)
> FileNotFoundError: [Errno 2] No such file or directory: 'git'
>
> So, I think we need to patch the source code to call the full path to git,
> or otherwise wrap the 'git-review' executable.
>
> > + (home-page "http://docs.openstack.org/infra/git-review/")
> > + (synopsis "Command-line tool for Gerrit")
> > + (description
> > + "Git-review is a command-line tool that helps submitting Git branches
> > to
> > +Gerrit for review, or fetching existing ones.")
> > + (license asl2.0)))
> Otherwise seems OK to me. Can you test with environment -C -N?
> ben
>
Oh no! I just pushed this.
--
Efraim Flashner <address@hidden> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature
- [PATCH] gnu: Add git-review., Clément Lassieur, 2016/09/08
- Re: [PATCH] gnu: Add git-review., Vincent Legoll, 2016/09/08
- Re: [PATCH] gnu: Add git-review., Efraim Flashner, 2016/09/08
- Re: [PATCH] gnu: Add git-review., Ben Woodcroft, 2016/09/08
- Re: [PATCH] gnu: Add git-review.,
Efraim Flashner <=
- Re: [PATCH] gnu: Add git-review., Efraim Flashner, 2016/09/08
- Re: [PATCH] gnu: Add git-review., Clément Lassieur, 2016/09/09
- Re: [PATCH] gnu: Add git-review., Efraim Flashner, 2016/09/09
- Re: [PATCH] gnu: Add git-review., Clément Lassieur, 2016/09/09
- Re: [PATCH] gnu: Add git-review., Efraim Flashner, 2016/09/10
- [PATCH] gnu: python-git-review: Wrap it so 'git', 'ssh' and 'scp' are found., Clément Lassieur, 2016/09/10
- Re: [PATCH] gnu: python-git-review: Wrap it so 'git', 'ssh' and 'scp' are found., Efraim Flashner, 2016/09/11
- Re: [PATCH] gnu: Add git-review., Clément Lassieur, 2016/09/10