Re: [PATCH] gnu: Add tcp-wrappers.

[Ludovic Courtès]

John Darrington <address@hidden> skribis:

> * gnu/packages/networking.scm (tcp-wrappers): New variable.
> * gnu/packages/messaging.scm (ngircd) [inputs]: Add tcp-wrappers.

Could you commit the second part separately?

> +               (map (lambda (x)
> +                      (install-file x (string-append
> +                                    (assoc-ref %outputs "out")
> +                                   "/include"))) headers)
> +               (map (lambda (x)
> +                      (install-file x (string-append
> +                                    (assoc-ref %outputs "out")
> +                                   "/share/man/man"
> +                                   (string-take-right x 1)))) man-pages)
> +               (map (lambda (x)
> +                      (install-file x (string-append
> +                                    (assoc-ref %outputs "out")
> +                                   "/lib/"))) libs)
> +               (map (lambda (x)
> +                      (install-file x (string-append
> +                                    (assoc-ref %outputs "out")
> +                                    "/bin/"))) bins)))))))

Please use the ‘out’ variable defined above, use ‘for-each’, and fix the
indentation:

  (for-each (lambda (file)
              (install-file file (string-append out "/bin")))
            bins)

> +    (home-page "http://www.porcupine.org";)
> +    (synopsis  "Monitor and filter incoming requests for network services")
> +    (description "With this package you can monitor and filter incoming 
> requests for
> +network services.  It includes a library which may be used by daemons to
> +transparently check connection attempts against an access control list.")
> +   (license (license:non-copyleft "file://DISCLAIMER"
      ^
Alignment.  :-)

OK with these changes, thank you!

Ludo’.