guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] gnu: Add cfitsio


From: Leo Famulari
Subject: Re: [PATCH 1/3] gnu: Add cfitsio
Date: Tue, 30 Aug 2016 16:47:18 -0400
User-agent: Mutt/1.7.0 (2016-08-17)

On Tue, Aug 30, 2016 at 09:21:10PM +0200, John Darrington wrote:
> +       (uri (string-append
> +        "http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/"; name version
> +        ".tar.gz")) 

I would indent this based on (string-append).

> +         (add-after 'unpack 'replace-slash-bin

I would call this "patch-paths" or something like that, in order to
communicate the intention.

Otherwise LGTM.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]