[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add gzstream.
From: |
Eric Bavier |
Subject: |
Re: [PATCH] gnu: Add gzstream. |
Date: |
Tue, 30 Aug 2016 13:48:46 -0500 |
Thanks for the patch! Comments below:
On Tue, 30 Aug 2016 19:17:14 +0100
Marius Bakke <address@hidden> wrote:
> From 5e96b895c1ed77a6bfdcbe5c6dbd68220fd5a8dc Mon Sep 17 00:00:00 2001
> From: Marius Bakke <address@hidden>
> Date: Fri, 12 Aug 2016 02:29:51 +0100
> Subject: [PATCH 1/1] gnu: Add gzstream.
>
> * gnu/packages/compression.scm (gzstream): New variable.
> ---
> [...]
> + (source (origin
> + (method url-fetch)
> + (uri
> + ;; No versioned URL, but last release was in 2003.
> +
> "http://www.cs.unc.edu/Research/compgeom/gzstream/gzstream.tgz")
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "00y19pqjsdj5zcrx4p9j56pl73vayfwnb7y2hvp423nx0cwv5b4r"))))
There's a gzstream.o file in the tarball. Could you remove it an origin
snippet?
> [...]
> + (home-page "http://www.cs.unc.edu/Research/compgeom/gzstream/")
> + (synopsis "C++ library that provides the functionality of zlib in a C++
> iostream")
Maybe: "Compressed C++ iostream"
> + (description "gzstream is a small library for providing zlib
> functionality in a C++
> +iostream. It is basically just a wrapper.")
The second sentence may be left off, IMO.
> + (license license:lgpl2.1)))
^
This should be lgpl2.1+ because of the "or later" in the file headers.
Could you send an updated patch?
`~Eric