guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] gnu: node: Use compression: prefix.


From: Alex Kost
Subject: Re: [PATCH 4/4] gnu: node: Use compression: prefix.
Date: Sat, 27 Aug 2016 23:42:16 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Jelle Licht (2016-08-27 14:23 +0300) wrote:

> * gnu/packages/node.scm (define-module): Import gnu packages compression
>   with a prefix
> (node): Likewise.
> ---
>  gnu/packages/node.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
>
> diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
> index 7c020e6..351e988 100644
> --- a/gnu/packages/node.scm
> +++ b/gnu/packages/node.scm
> @@ -27,7 +27,8 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (gnu packages adns)
>    #:use-module (gnu packages base)
> -  #:use-module (gnu packages compression)
> +  #:use-module ((gnu packages compression) #:prefix compression:)
> +  #:use-module (gnu packages curl)
>    #:use-module (gnu packages gcc)
>    #:use-module (gnu packages libevent)
>    #:use-module (gnu packages linux)

This patch is incomplete: you introduce 'compression' prefix, but you
use it in the previous patch.

Actually, why is this prefix needed?

Also why did you add curl module if it's not used at all?

-- 
Alex



reply via email to

[Prev in Thread] Current Thread [Next in Thread]