Re: [PATCH] Add tintin.

[ng0]

Hi,

Leo Famulari <address@hidden> writes:

> On Mon, Aug 08, 2016 at 09:21:09PM +0000, ng0 wrote:
>> Updated patch.
>> 
>> * gnu/packages/games.scm (tintin): New variable.
>
> Thanks!
>
>> +              (uri (string-append "https://sourceforge.net/projects/tintin";
>> +                                  "/files/TinTin++ Source Code/" version
>> +                                  "/tintin" "-" version ".tar.gz"))
>
> This URL does not work for me. Maybe you already had the tarball in your
> /gnu/store? Also, it should use our SourceForge mirrors.

The mirror://sourceforge uses /project/, while this uses /projects/.
Just /project/ failed for me, as did the mirrors.

>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         ;; The source is in tt/src.
>> +         (add-before 'configure 'chdir-to-tt-src
>> +           (lambda _
>> +             (chdir "src"))))))
>
> I would call this phase 'chdir'.

Okay I will update when we can solve the url above.
Their download site, http://tintin.sourceforge.net/download.php, says:
http://sourceforge.net/projects/tintin/files/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz/download

And when I try /project/ instead of /projects/ I get:
address@hidden ~$ wget 
http://sourceforge.net/project/tintin/files/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz/download
--2016-08-19 20:35:45--
http://sourceforge.net/project/tintin/files/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz/download
Resolving sourceforge.net (sourceforge.net)... 216.34.181.60
Connecting to sourceforge.net (sourceforge.net)|216.34.181.60|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location:
https://sourceforge.net/project/tintin/files/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz/download
 [following]
--2016-08-19 20:35:45--
https://sourceforge.net/project/tintin/files/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz/download
Connecting to sourceforge.net
(sourceforge.net)|216.34.181.60|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2016-08-19 20:35:46 ERROR 404: Not Found.

while /projects/ would resolve:

address@hidden ~$ wget
http://sourceforge.net/projects/tintin/files/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz/download
--2016-08-19 20:38:53--
http://sourceforge.net/projects/tintin/files/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz/download
Resolving sourceforge.net (sourceforge.net)... 216.34.181.60
Connecting to sourceforge.net
(sourceforge.net)|216.34.181.60|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location:
https://sourceforge.net/projects/tintin/files/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz/download
[following]
--2016-08-19 20:38:56--
https://sourceforge.net/projects/tintin/files/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz/download
Connecting to sourceforge.net
(sourceforge.net)|216.34.181.60|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location:
http://downloads.sourceforge.net/project/tintin/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz?r=&ts=1471639137&use_mirror=netix
[following]
--2016-08-19 20:38:57--
http://downloads.sourceforge.net/project/tintin/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz?r=&ts=1471639137&use_mirror=netix
Resolving downloads.sourceforge.net
(downloads.sourceforge.net)... 216.34.181.59
Connecting to downloads.sourceforge.net
(downloads.sourceforge.net)|216.34.181.59|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location:
http://netix.dl.sourceforge.net/project/tintin/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz
[following]
--2016-08-19 20:38:57--
http://netix.dl.sourceforge.net/project/tintin/TinTin%2B%2B%20Source%20Code/2.01.1/tintin-2.01.1.tar.gz
Resolving netix.dl.sourceforge.net
(netix.dl.sourceforge.net)... 87.121.121.2
Connecting to netix.dl.sourceforge.net
(netix.dl.sourceforge.net)|87.121.121.2|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 272506 (266K) [application/x-gzip]
Saving to: ‘download’

download
100%[===============================================================================================>]
266.12K   850KB/s    in 0.3s

2016-08-19 20:38:58 (850 KB/s) - ‘download’ saved [272506/272506]


>
>> +    (home-page "http://tintin.sourceforge.net/";)
>
> HTTPS, if possible.

In this case, no. This sourceforge subdomain has no tls option:
Oops! Unable to display this website.
The site at “https://tintin.sourceforge.net/” seems to be
unavailable. The precise error was:
Could not connect: Connection refused
It may be temporarily unavailable or moved to a new address. You may
wish to verify that your internet connection is working correctly.

>
> Otherwise, looks good so far!

Thanks
-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org