[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/24] gnu: gnome: Add mobile-broadband-provider-info.
From: |
Mark H Weaver |
Subject: |
Re: [PATCH 12/24] gnu: gnome: Add mobile-broadband-provider-info. |
Date: |
Wed, 17 Aug 2016 05:33:03 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
David Craven <address@hidden> writes:
> * gnu/packages/gnome.scm (mobile-broadband-provider-info): New variable.
The summary line to should be "gnu: Add mobile-broadband-provider-info."
without the "gnome: ". By our conventions, starting a summary line with
"gnu: gnome: " indicates a change to the 'gnome' package, which is not
the case here, and leads to confusion in practice. I read this summary
line as meaning that 'mobile-broadband-provider-info' was added to
gnome's propagated-inputs.
This same issue applies to the other patches in this patch set as well.
When adding new packages, our convention is simply to write "gnu: Add
<package-name>."
Thanks,
Mark
> ---
> gnu/packages/gnome.scm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 4a0be01..7bc0445 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -21,6 +21,7 @@
> ;;; Copyright © 2016 Leo Famulari <address@hidden>
> ;;; Copyright © 2016 Alex Griffin <address@hidden>
> ;;; Copyright © 2016 ng0 <address@hidden>
> +;;; Copyright © 2016 David Craven <address@hidden>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -4460,6 +4461,27 @@ devices, and provides VPN integration with a variety
> of different VPN
> services.")
> (license license:gpl2+)))
>
> +(define-public mobile-broadband-provider-info
> + (package
> + (name "mobile-broadband-provider-info")
> + (version "20151214")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://gnome/sources/"
> + "mobile-broadband-provider-info/" version "/"
> + "mobile-broadband-provider-info-" version ".tar.xz"))
> + (sha256
> + (base32
> + "1905nab1h8p4hx0m1w0rn4mkg9209x680dcr4l77bngy21pmvr4a"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f)) ; No tests
> + (home-page "https://wiki.gnome.org/Projects/NetworkManager")
> + (synopsis "Datbase of broadband connection configuration")
> + (description "Datbase of broadband connection configuration.")
> + (license license:public-domain)))
> +
> (define-public network-manager-applet
> (package
> (name "network-manager-applet")
- [PATCH 08/24] gnu: xorg: Add lndir., (continued)
- [PATCH 08/24] gnu: xorg: Add lndir., David Craven, 2016/08/16
- [PATCH 15/24] gnu: gstreamer: Symlink gstconfig.h into include directory., David Craven, 2016/08/16
- [PATCH 09/24] gnu: freedesktop: Add wayland-protocols., David Craven, 2016/08/16
- [PATCH 12/24] gnu: gnome: Add mobile-broadband-provider-info., David Craven, 2016/08/16
- [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager., David Craven, 2016/08/16
- [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure., David Craven, 2016/08/16
- [PATCH 13/24] gnu: polkit-qt: Use modular qt., David Craven, 2016/08/16
- [PATCH 16/24] gnu: gstreamer: Add qt-gstreamer., David Craven, 2016/08/16