[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/24] gnu: xorg: Add lndir.
From: |
David Craven |
Subject: |
Re: [PATCH 08/24] gnu: xorg: Add lndir. |
Date: |
Wed, 17 Aug 2016 10:35:38 +0200 |
> The patch looks good to me, except the indentation of this
>
> (string-append ...). I usually write 'source' fields like this:
>
> (source (origin
> (method url-fetch)
> (uri (string-append "mirror://xorg/individual/util/lndir-"
> version ".tar.bz2"))
> (sha256
> (base32
> "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
>
> But this is not a big deal, of course :-)
I prefer
(uri (string-append
"mirror://xorg/individual/util/"
"lndir-" version ".tar.bz2"))
But in this case I thought that keeping consistent with how it was
done in the xorg.scm file was more important than my preference. What
do you think?
- Re: [PATCH 08/24] gnu: xorg: Add lndir.,
David Craven <=