[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] Perl 5.24.0 update
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH 0/1] Perl 5.24.0 update |
Date: |
Wed, 17 Aug 2016 09:01:51 +0200 |
User-agent: |
mu4e 0.9.16; emacs 25.1.1 |
Leo Famulari <address@hidden> writes:
> On Tue, Aug 16, 2016 at 06:43:57PM -0400, Leo Famulari wrote:
>> And the perl-no-build-time patch deactivated the code that embedded the
>> compilation timestamp that is normally printed by `perl -V`. Perl 5.24.0
>> can take this value from the macro PERL_BUILD_DATE [2], so I removed the
>> old patch and added perl-reproducible-build-date.patch.
>>
>> I don't love this patch... we could instead do something like what
>> happens in the Erlang package. There we instead get SOURCE_DATE_EPOCH
>> from the environment and do some format string transformations to make a
>> pretty date string.
>
> We could also just keep the perl-no-build-time patch in place. There is
> not much point in doing work just to make `perl -V` print a nonsense
> date (Unix epoch) IMO.
What you sent looks good. It is important to let “perl -V” print a date
(even if it is useless) to avoid breaking third-party software that
expects a date to be printed.
Your patch to just define the date as the epoch seems fine to me.
~~ Ricardo