guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: python: add pyserial.


From: Leo Famulari
Subject: Re: [PATCH] gnu: python: add pyserial.
Date: Mon, 15 Aug 2016 20:29:40 -0400
User-agent: Mutt/1.6.0 (2016-04-01)

On Mon, Aug 15, 2016 at 02:25:01PM +0200, Danny Milosavljevic wrote:
> 
> * gnu/packages/python.scm (python-pyserial, python-pyserial2): New variables.

Thank for this package!

> +      (uri (string-append
> +             "https://pypi.python.org/packages/";
> +             
> "3c/d8/a9fa247ca60b02b3bebbd61766b4f321393b57b13c53b18f6f62cf172c08/"
> +             "pyserial-" version ".tar.gz"))

It's much shorter to use pypi-uri.

> +  (inputs
> +    `(("python-setuptools" ,python-setuptools)))

Was this left in from some previous version of the package? If so, it
should be removed, and you will need to add a (properties ...) field to
make the python2-variant system work for python2-pyserial. See the
package definition of python-pythondialog for an example.

> +  (license license:bsd-3)))

The "license:" prefix should be removed. The package can't be built with
it.

Can you send an updated patch?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]