Re: [PATCH] gnu: Add sg3_utils.

[Chris Marusich]

Leo Famulari <address@hidden> writes:

> Thanks for this patch! How about putting it in disk.scm? I have no
> strong preference either way. I don't like moving things around too much
> once they have been created, however :)

sg3_utils and its library can be used with any SCSI device, which
includes many devices which are not hard disks, such as CD-ROMs and
media changers (i.e., jukeboxes), so I don't think it makes sense to put
it into a file whose scope is limited to disks.

>> +  #:use-module ((guix licenses)
>> +                #:select (gpl2+ bsd-3))
>
> Do we need to use #:select here? How about using a license prefix? What
> are the pros and cons?
>
>> +(define-public sg3_utils
>> +  (package
>> +    (name "sg3_utils")
>
> We like to use underscores instead of hyphens in package names:
>
> https://www.gnu.org/software/guix/manual/html_node/Package-Naming.html#Package-Naming

Thank you for pointing this out.  I've updated it (see attached patch).

>> +    (description
>> +     "sg3_utils is a collection of utilities for devices that use the Small
>> +Computer System Interface (SCSI) command set.  It includes utilities to read
>> +data from, write data to, control, modify, and query the state of SCSI
>> +devices.  For example, this package provides command-line tools to copy data
>> +based on \"dd\" syntax and semantics (called sg_dd, sgp_dd and sgm_dd), 
>> check
>> +INQUIRY data and VPD pages (sg_inq), check mode and log pages (sginfo,
>> +sg_modes and sg_logs), spin up and down disks (sg_start), do self
>> +tests (sg_senddiag), parse sense data, and perform various other functions.
>> +In addition, this package includes a library, called libsgutils, which can 
>> be
>> +used in C and C++ programs to interact with SCSI devices.")
>
> I think that dd, and all the sg_* commands, should be wrapped in texinfo
> markup, like this:
>
> @code{dd}

Done!  Thanks for the tip.

-- 
Chris

0001-gnu-Add-sg3_utils.patch
Description: Text Data

signature.asc
Description: PGP signature