Re: [PATCH] gnu: Add python-stem.

[ng0]

ng0 <address@hidden> writes:

> [ Unknown signature status ]
> These 2 patches add python-stem and python2-stem.
>
> From 422e5aea16aafbc76a1480b577eef1fecfbf45ec Mon Sep 17 00:00:00 2001
> From: ng0 <address@hidden>
> Date: Thu, 11 Aug 2016 13:42:22 +0000
> Subject: [PATCH 1/2] gnu: Add python-stem.
>
> * gnu/packages/python.scm (python-stem): New variable.
> ---
>  gnu/packages/python.scm | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 6ff1c5c..f3245cc 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -45,7 +45,7 @@
>                  #:select (asl2.0 bsd-4 bsd-3 bsd-2 non-copyleft cc0 x11 
> x11-style
>                            gpl2 gpl2+ gpl3 gpl3+ lgpl2.0+ lgpl2.1 lgpl2.1+ 
> lgpl3+ agpl3+
>                            isc mpl2.0 psfl public-domain repoze unlicense 
> x11-style
> -                          zpl2.1))
> +                          zpl2.1 lgpl3))
>    #:use-module ((guix licenses) #:select (expat zlib) #:prefix license:)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages algebra)
> @@ -9852,3 +9852,34 @@ etc.")
>      (package
>        (inherit base)
>        (name "ptpython2"))))
> +
> +(define-public python-stem
> +  (package
> +    (name "python-stem")
> +    (version "1.4.1b")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "stem" version ".tar.bz2"))
> +       (sha256
> +        (base32
> +         "09a3amp1y351nwz088ckiibbp666qi2lxwkyknavswfm400s0ns7"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases
> +       (alist-replace
> +        'check
> +        (lambda _
> +          (zero? (system* "./run_tests.py" "--unit")))
> +        %standard-phases)))
> +    (inputs
> +     `(("python-setuptools" ,python-setuptools)
> +       ("python-mock" ,python-mock)))

This should probably be native-inputs. mock is needed for tests,
setuptools only for the setup.
I have see packages doing it in inputs and native-inputs, but
native-inputs is more logical. I'll submit a changed patch and you can
pick what you like.

> +    (home-page "https://stem.torproject.org/";)
> +    (synopsis
> +     "Stem is a Python controller library that allows applications to 
> interact with Tor")
> +    (description
> +     "Stem is a Python controller library for Tor.  With it you can use Tor's
> +control protocol to script against the Tor process and read descriptor data 
> relays
> +publish about themselves.")
> +    (license lgpl3)))
> -- 
> 2.9.2
>
> From 5c2c742cddccfcfdef74aeb99f125fe4ee401a2e Mon Sep 17 00:00:00 2001
> From: ng0 <address@hidden>
> Date: Thu, 11 Aug 2016 14:08:33 +0000
> Subject: [PATCH 2/2] gnu: Add python2-stem.
>
> * gnu/packages/python.scm (python2-stem): New variable.
> ---
>  gnu/packages/python.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index f3245cc..cbdf0a6 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -9883,3 +9883,6 @@ etc.")
>  control protocol to script against the Tor process and read descriptor data 
> relays
>  publish about themselves.")
>      (license lgpl3)))
> +
> +(define-public python2-stem
> +  (package-with-python2 python-stem))
> -- 
> 2.9.2
>
>
> -- 
> ♥Ⓐ  ng0
> For non-prism friendly talk find me on http://www.psyced.org

-- 
♥Ⓐ  ng0
For non-prism friendly talk find me on http://www.psyced.org