Re: [PATCH] gnu: Add ircii.

[Ricardo Wurmus]

ng0 <address@hidden> writes:

> From 1438e5654cfd5f4eb4141a42580bd73c716e7134 Mon Sep 17 00:00:00 2001
> From: ng0 <address@hidden>
> Date: Mon, 1 Aug 2016 19:31:23 +0000
> Subject: [PATCH] gnu: Add ircii.

> * gnu/packages/irc.scm (ircii): New variable.
> ---
>  gnu/packages/irc.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)

> diff --git a/gnu/packages/irc.scm b/gnu/packages/irc.scm
> index 03f014a..7087022 100644
> --- a/gnu/packages/irc.scm
> +++ b/gnu/packages/irc.scm
> @@ -194,3 +194,49 @@ with a keyboard, though it also supports mouse.  It is 
> customizable
>  and extensible with plugins and scripts.")
>      (home-page "http://www.weechat.org/";)
>      (license license:gpl3)))
> +
> +(define-public ircii
> +  (package
> +    (name "ircii")
> +    (version "20151120")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append "https://ircii.warped.com/";
> +                                 name "-" version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "178dc279f5j894qvp96dzz7c0jpryqlcqw5g0dc9yaxg9kgw1lqm"))))
> +    (build-system gnu-build-system)
> +    ;; TODO: Configure with socks client (ghc-socks is too big).
> +    (arguments
> +     `(#:tests? #f

Please add a comment like “; no tests”.

> +       #:configure-flags (list
> +                          ;;(string-append "--prefix=" (assoc-ref %outputs 
> "out"))

I suppose this line can be removed?

> +                          "--enable-ipv6"
> +                          (string-append "--with-openssl="
> +                                         (assoc-ref %build-inputs "openssl"))
> +                          "--with-emacs-meta-keys")

What does this do?

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-bsdinstall-absolute-path-bins

That’s a somewhat unusual name for a phase.  In other packages we use
something simpler like “fix-paths” or “patch-paths”.

> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "bsdinstall"
> +               (("/bin/strip") "strip")
> +               (("/bin/cp") "cp")
> +               (("/bin/chmod") "chmod")
> +               (("/etc/chown") "chown")
> +               (("/bin/chgrp") "chgrp")
> +               (("/bin/mkdir") "mkdir")
> +               (("/bin/rm") "rm")
> +               (("/bin/mv") "mv")))))))

Four things:

- you don’t use the “inputs” key, so you can simplify this to “(lambda _ …)”
- “/etc/chown”?
- can this be simplified by just deleting any occurrence of “/bin/”?
- please end this phase with “#t” as “substitute*” has no defined return value.

> +    (inputs
> +     `(("ncurses" ,ncurses)
> +       ("openssl" ,openssl)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("perl" ,perl)))
> +    (home-page "http://www.eterna.com.au/ircii/";)
> +    (synopsis "Terminal-based IRC and ICB client")
> +    (description
> +     "ircII is a terminal based IRC and ICB client for UNIX systems.")

I’d remove “for UNIX systems”.  Is there more that can be said about
this application?

> +    (license license:bsd-3)))
> -- 
> 2.9.2

~~ Ricardo