[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: bash-completion: Update to 2.3.
|
From: |
Andreas Enge |
|
Subject: |
Re: [PATCH] gnu: bash-completion: Update to 2.3. |
|
Date: |
Fri, 5 Aug 2016 20:53:46 +0200 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
Hello,
On Wed, Aug 03, 2016 at 10:53:11AM +0200, Tomáš Čech wrote:
> * gnu/packages/bash.scm(bash-completion): Update to 2.3, add autoreconf
> phase, change origin to Github.
> * gnu/packages/patches/bash-completion-directories.patch: Rework - same
> purpose, different code.
just the quick standard comment: Please do the switch from alist-...
to modify-phases in a separate first commit; it makes it easier to see
the real diff of your real commit.
The autoreconf phase is strange. Why is it suddenly needed? If there is no
way around it, you should at least add a comment.
Andreas
- [PATCH] gnu: bash-completion: Update to 2.3., Tomáš Čech, 2016/08/03
- Re: [PATCH] gnu: bash-completion: Update to 2.3.,
Andreas Enge <=
- Re: [PATCH] gnu: bash-completion: Update to 2.3., Leo Famulari, 2016/08/06
- Re: [PATCH] gnu: bash-completion: Update to 2.3., Tomáš Čech, 2016/08/07
- [PATCHv2 1/2] gnu: bash-completion: Modify to modify-phases., Tomáš Čech, 2016/08/07
- [PATCHv2 2/2] gnu: bash-completion: Update to 2.3. Update the patch., Tomáš Čech, 2016/08/07
- Re: [PATCHv2 2/2] gnu: bash-completion: Update to 2.3. Update the patch., Leo Famulari, 2016/08/08
- Re: [PATCHv2 2/2] gnu: bash-completion: Update to 2.3. Update the patch., Tomáš Čech, 2016/08/09
- Re: [PATCHv2 1/2] gnu: bash-completion: Modify to modify-phases., Leo Famulari, 2016/08/08