Re: [PATCH] system: grub: Introduce foreign-menu-entry.

[Chris Marusich]

Tomáš Čech <address@hidden> writes:

> I'd like to store configuration of other linux distribution and so far
> I haven't found how to override hardcoded bzImage suffix.
>
> With this change I can have configuration:
>
> (bootloader (grub-configuration
>             (device "/dev/sda")
>             (menu-entries
>              (list
>               (foreign-menu-entry
>                (label "openSUSE")
>                (device "(hd0,1)")
>                (linux "/vmlinuz")
>                (linux-arguments (list
>                                  "root=/dev/venom/opensuse"
>                                  "init=/usr/lib/systemd/systemd"))
>                (initrd "/initrd")
>                )))))
>
> which will transform to:
>
> menuentry "openSUSE" {
>  linux (hd0,1)/vmlinuz root=/dev/venom/opensuse init=/usr/lib/systemd/systemd
>  initrd (hd0,1)/initrd
> }

I see!  Yes, I agree it would be nice to be able to do that.

> My intention was to introduce new record type to distinguish between
> menu-entry and foreign-menu-entry later in the code. Different type,
> different interpretation.

I see what you're saying, but I think the alternative which Ludo
proposed in the following bug report is cleaner because it re-uses the
existing record type:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20067

What do you think?

> Code was using match-lambda so defining new type to distinguish the
> cases seemed to me natural. Again, I'm new to Guile and I'd like to
> see how to do that right. This worked for me as first solution.

That's totally understandable.  I'm new to Guile, also, so I might not
always be right, either.  Thank you for taking the time to submit a
patch to improve the project!

-- 
Chris

signature.asc
Description: PGP signature