[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: guix bootloader selection - wip patch
From: |
Danny Milosavljevic |
Subject: |
Re: guix bootloader selection - wip patch |
Date: |
Fri, 29 Jul 2016 10:21:55 +0200 |
> Really, installing U-Boot is as simple as this? If it is, that’s
> perfect. :-)
Nope, it's just a placeholder :)
But ideally U-Boot would provide something like that.
I'm looking into writing u-boot-install.c and maybe contributing it to U-Boot -
let's see how bad it is.
Right now checking whether libparted allows you to reduce the size of the GPT
to max. 56 entries...
> I would write it as:
>
> (match bootloader-configuration
> ((? grub-configuration? config)
> (grub-configuration-device config))
> ((? u-boot-configuration? config)
> (u-boot-configuration-device config)))
> which does the same thing but allows us to avoid exporting
> <grub-configuration> and <u-boot-configuration> (better to keep them
> private so that external code doesn’t rely on the structure layout.)
Yeah, I changed it to that now and removed the exports.
> I see three separate things here:
>
> 1. Replacing “grub” by “bootloader” in the API (cosmetic change);
>
> 2. Adding the build-side code to install U-Boot;
>
> 3. Adding the host-side code to handle <u-boot-configuration> and do
> the right thing.
>
> To facilitate review, could you separate these three things?
As far as they are in different files, yes. Which part is the build-side, which
part is the host-side?
> Also, not critical, but could you send patches as ‘text/x-patch’ MIME
> attachments so that my email client can perform color highlighting? :-)
Okay.