[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] Improve the pypi updater.
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH 0/5] Improve the pypi updater. |
|
Date: |
Fri, 22 Jul 2016 23:22:03 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hello!
Cyril Roelandt <address@hidden> skribis:
> A couple of minor improvements, and a huge one: we should now be able to
> automatically compute the test requirements of our Python packages!
Neat! So the test dependencies go to ‘inputs’ instead of
‘propagated-inputs’, right? That can definitely save time and avoid
errors.
Is there an example package that illustrates this?
> * guix/import/pypi.scm (maybe-inputs): Pass INPUT-TYPE as a parameter.
> * guix/import/pypi.scm (make-pypi-sexp): Use this parameter.
Nitpick: no need to repeat the file name.
> * tests/pypi.scm ("pypi->guix-package", "pypi->guix-package, wheels"): Update
> accordingly.
LGTM!
Thanks,
Ludo’.