guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-


From: Ludovic Courtès
Subject: Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.
Date: Thu, 21 Jul 2016 14:24:36 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

David Craven <address@hidden> skribis:

>> I think packages with a “bin” output are not always used as native
>> inputs, so I would drop this rule.
>
> From searching the code-base we have I couldn't find a counter example. Do
> you think it's ok to check for glib:bin specifically?

Yes, sounds good to me.

However, make sure to match on the package name + output, not on the
label.  That is, ‘lint’ should correctly diagnose something like:

  (inputs `(("somethingsilly" ,glib "bin")))

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]