guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] services: Add rngd-service.


From: Ludovic Courtès
Subject: Re: [PATCH 3/4] services: Add rngd-service.
Date: Tue, 05 Jul 2016 11:11:23 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

David Craven <address@hidden> skribis:

> * gnu/services/base.scm: New service.
> * doc/guix.texi: Add documentation.

Neat!  I adjusted the commit log and made minor changes:

> +(define-record-type* <rngd-configuration>
> +  rngd-configuration make-rngd-configuration
> +  rngd-configuration?
> +  (rng-tools rngd-configuration-rng-tools)
> +  (rng-device rngd-configuration-rngd-device))

I changed “rng-device” to “device” here and in similar places (“rng”
seemed redundant.)

> +(define* (rngd-service #:key
> +  (rng-tools rng-tools)
> +  (rng-device "/dev/hwrng"))

Reindented this.

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]