[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: Correctly determine the system type for GNU/Hurd syst
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] build: Correctly determine the system type for GNU/Hurd systems. |
Date: |
Sun, 19 Jun 2016 15:57:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Manolis Ragkousis <address@hidden> skribis:
> From b4aae91b25930b8f5cdb8af802e480eca8caf12e Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <address@hidden>
> Date: Sat, 26 Mar 2016 16:53:40 +0200
> Subject: [PATCH] build: Correctly determine the system type for GNU/Hurd
> systems.
>
> * m4/guix.m4 (GUIX_SYSTEM_TYPE): Add case for gnu.
> ---
> m4/guix.m4 | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/m4/guix.m4 b/m4/guix.m4
> index 2d3dfd2..3396e05 100644
> --- a/m4/guix.m4
> +++ b/m4/guix.m4
> @@ -74,6 +74,9 @@ AC_DEFUN([GUIX_SYSTEM_TYPE], [
> linux-gnu*)
> # For backward compatibility, strip the `-gnu' part.
> guix_system="$machine_name-linux";;
> + gnu*)
> + # When on Hurd, use i586 always.
“Always use i586 for GNU/Hurd.”
Apart from that, LGTM!
I wonder why this is needed though; normally, when building on
i586-unknown-gnu*, the next case:
--8<---------------cut here---------------start------------->8---
case "$host_os" in
linux-gnu*)
# For backward compatibility, strip the `-gnu' part.
guix_system="$machine_name-linux";;
*) # ← THIS CASE
# Strip the version number from names such as `gnu0.3',
# `darwin10.2.0', etc.
guix_system="$machine_name-`echo $host_os | "$SED"
-e's/[0-9.]*$//g'`";;
esac
--8<---------------cut here---------------end--------------->8---
… should produce “i586-gnu”, no? What did you observe? To put it
differently, what does ./build-aux/config.guess return on a GNU/Hurd
system?
Thanks,
Ludo’.