[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5] gnu: Add teensy-loader-cli.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH v5] gnu: Add teensy-loader-cli. |
Date: |
Wed, 15 Jun 2016 15:31:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hello,
Hartmut Goebel <address@hidden> skribis:
> * gnu/packages/flashing-tools.scm (teensy-loader-cli): New variable.
> * gnu/packages/patches/teensy-loader-cli-Add-support-for-h-help.patch,
> gnu/packages/patches/teensy-loader-cli-Change-program-name-in-usage.patch
> New files.
I’ve finally applied it and took the liberty to make a few changes (I
didn’t want to bother you another time!).
> + (patches (search-patches
> + "teensy-loader-cli-Add-support-for-h-help.patch"
> + "teensy-loader-cli-Change-program-name-in-usage.patch"))))
I removed the second patch and corresponding renaming (I hadn’t noticed
it before), on the grounds that it’s not our job to rename things; in
general, we should stick to what upstream has chosen.
I’ve also added the remaining patch to gnu/local.mk.
> +++ b/gnu/packages/patches/teensy-loader-cli-Add-support-for-h-help.patch
> @@ -0,0 +1,34 @@
> +Add support for `-h` (help).
> +This option was already in the usage message, but not implemented.
> +
> +Upstream pull-request pending.
I added the URL of the pull request instead.
Note that, normally, we would not incorporate such patches, because it’s
really upstream’s business, not ours.
Thank you!
Ludo’.
[PATCH v5] gnu: Add teensy-loader-cli., Hartmut Goebel, 2016/06/14
Re: [PATCH] Add more symlinks to python-wrapper, Hartmut Goebel, 2016/06/14