Re: [PATCH 01/10] gnu: Add emacs-smex.

[Alex Kost]

David Thompson (2016-06-01 17:05 +0300) wrote:

> From: David Thompson <address@hidden>
>
> * gnu/packages/emacs.scm (emacs-smex): New variable.
> ---
>  gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index b7c0a1f..71f2f8b 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -10,6 +10,7 @@
>  ;;; Copyright © 2015, 2016 Christopher Allan Webber <address@hidden>
>  ;;; Copyright © 2016 humanitiesNerd <address@hidden>
>  ;;; Copyright © 2016 Efraim Flashner <address@hidden>
> +;;; Copyright © 2016 David Thompson <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.")
>  Emacs default configuration in uncontroversial ways that nearly everyone can
>  agree upon.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-smex
> +  (package
> +    (name "emacs-smex")
> +    (version "3.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://raw.githubusercontent.com";
> +                                  "/nonsequitur/smex/" version "/smex.el"))

Hm, I see in some packages you use these "githubusercontent" URLs
instead of <https://github.com/nonsequitur/smex/archive/3.0.tar.gz> as
we usually do for github.  IIUC you did it to avoid extra files
(".gitignore", etc.) in the final package directory, right?  If so, I
think it is not needed, I would still use a link to a tagged source code
archive.  Moreover I think it's a problem of emacs-build-system that
these uninteresting files are not removed.

Overall, I don't mind against "githubusercontent", I was just wondering.
Actually, I think you found a good way how to pick the needed files to
make several packages from a single repo (as you did for
"ido-ubiquitous" and "ido-completing-read+").

> +              (file-name (string-append "smex-" version ".el"))
> +              (sha256
> +               (base32
> +                "0ar310zx9k5y4i1vl2rawvi712xj9gx77160860jbs691p77cxqp"))))
> +    (build-system emacs-build-system)
> +    (home-page "http://github.com/nonsequitur/smex/";)
> +    (synopsis "M-x interface with Ido-style fuzzy matching")
> +    (description
> +     "Smex is a M-x enhancement for Emacs.  Built on top of Ido, it provides 
> a
> +convenient interface to your recently and most frequently used commands.  And
> +to all the other commands, too.")
> +    (license license:gpl3+)))

-- 
Alex