Re: [PATCH] gnu: Add gparted.

[Leo Famulari]

On Sat, May 28, 2016 at 08:34:19PM +0200, Roel Janssen wrote:
> Leo Famulari writes:
> > On Sat, May 28, 2016 at 05:52:16PM +0200, Roel Janssen wrote:
> I tested with a USB drive.  I could create a new partition table and a
> new partition.

Great!

> It seems all tests need to download DTDs from various places on the
> internet.  The tests are related to the use of Scrollkeeper (which I
> disabled).
> 
> As far as I can see there are no unit tests for the actual code.

Ah, too bad. I guess it relies on the tests for parted / libparted.

> >> +       #:configure-flags '("--disable-scrollkeeper")))
> >
> > I'm not sure what this means. Can you leave a comment explaining it?
> 
> Of course!  I'm not completely familiar with Scrollkeeper (although I
> also wrote a package recipe for it), but what I understand is that it is
> a program to manage various formats of documentation, and keep a central
> database that links to various forms of documentation.
> 
> I added the following comment, but I think explaining the ins and outs of
> Scrollkeeper goes too far.  Is the comment good enough?
> 
> +       ;; We don't use scrollkeeper elsewhere, so disable updating the
> +       ;; scrollkeeper database with documentation from GParted.
> +       #:configure-flags '("--disable-scrollkeeper")))

I think the comment is fine.

On a related topic, trying to open the help from the "Help" menu gives
me a dialog box this text:

"Unable to open GParted Manual help file

Failed to execute child process "yelp" (No such file or directory)"

I get the same result from the Debian package. I wonder if I would have
more success if I was running GNOME?

Since the man page doesn't include any information about using the
program, it would be good to make sure the help application at least
works on GNOME.