Re: [PATCH] emacs-pkg-info

[Alex Kost]

Catonano (2016-05-27 12:47 +0300) wrote:

> This patch should be committed before the one I sent previously
> (emacs-queue)
>
> This is an excerpt from the build log
>
> In toplevel form:
> test/pkg-info-test.el:34:1:Error: Cannot open load file: not a
> directory, pkg-info-dummy-package
> Compiling /gnu/store/38j122ni4zm2vcmfcyxhpd6l3qn8gh6g-emacs-pkg-info
> -0.6/share/emacs/site-lisp/guix.d/pkg-info-0.6/test/test-helper.el...
> Wrote /gnu/store/38j122ni4zm2vcmfcyxhpd6l3qn8gh6g-emacs-pkg-info-0.6/
> share/emacs/site-lisp/guix.d/pkg-info-0.6/test/test-helper.elc
>
> After pkg-info-dummy-package can't be found it gets successfully
> compiled
>
> I think this is not a problem and the resulting build can be
> delivered to Guix users.

Right, it's not a problem.  The files inside "test" subdir are not
"interesting".  If you install this package using Emacs package system
(from MELPA), these files will not be installed at all.  Only
"pkg-info.el" matters and it is compiled successfully.

> I report this here for completeness

Thanks.

> From b0a71125d45a43a464b72cf8262aebf874ce8bc3 Mon Sep 17 00:00:00 2001
> From: humanitiesNerd <address@hidden>
> Date: Thu, 26 May 2016 01:59:21 +0200
> Subject: gnu: Add new variable (emacs-pkg-info).

Hey, it should be:

  gnu: Add emacs-pkg-info.

I told you 4 times how the commit message should look like:

http://lists.gnu.org/archive/html/guix-devel/2016-05/msg00462.html
http://lists.gnu.org/archive/html/guix-devel/2016-05/msg00512.html
http://lists.gnu.org/archive/html/guix-devel/2016-05/msg00565.html
http://lists.gnu.org/archive/html/guix-devel/2016-05/msg00805.html

Could you be more attentive, please.  Otherwise I will annoy you with
the same comment again and again :-)

> * gnu/packages/emacs.scm (emacs-pkg-info): New variable.
> ---
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index e513dc6..347a573 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1709,3 +1709,27 @@ The purpose of this library is to wrap all the quirks 
> and hassle of
>  package.el into a sane API.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-pkg-info
> +  (package
> +    (name "emacs-pkg-info")
> +    (version "0.6")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/lunaryorn/pkg-info.el/archive/";
> +             version
> +             ".tar.gz"))

Although some people do it like this, I always prefer to avoid such
heavy line splitting, i.e. I think putting version and ".tar.gz" on one
line is more good-looking.

> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +          "1gy1jks5mmm02gg1c8gcyr4f8a9s5ggzhk56gv33b9mzjqzi5rd5"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs `(("emacs-epl" ,emacs-epl)))
> +    (home-page
> +     "https://github.com/lunaryorn/pkg-info.el";)

I would put (home-page "...") on a single line.

> +    (synopsis "Information about packages")
> +    (description
> +     "This library extracts information from installed packages.
> +")

Please remove this extra new line in the end of description.

> +    (license license:gpl3+)))

I don't know what's the problem but I can't apply this patch.  Git gives
me this error: "could not build fake ancestor".   Could you please
resend the updated patch (and emacs-queue as well)?

Thanks.

-- 
Alex