[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add emacs-clojure-mode
From: |
Alex Kost |
Subject: |
Re: [PATCH] gnu: Add emacs-clojure-mode |
Date: |
Thu, 19 May 2016 11:54:47 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Catonano (2016-05-18 18:09 +0300) wrote:
> From 6dc8470baf3493a93da3e3358136e5c9860d4e3a Mon Sep 17 00:00:00 2001
> From: humanitiesNerd <address@hidden>
> Date: Wed, 18 May 2016 15:41:47 +0200
> Subject: gnu: Add emacs-clojure-mode
^
This is a nitpick of course, but we put a period here...
> * gnu/packages/emacs.scm (emacs-clojure-mode): New variable
^
... and here.
> ---
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 32ed722..fb07bc7 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1612,3 +1612,41 @@ It is built on top of the custom theme support in
> Emacs 24 or later.")
> (license license:gpl3+)))
>
>
> +(define-public emacs-clojure-mode
> + (package
> + (name "emacs-clojure-mode")
> + (version "5.3.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/clojure-emacs/clojure-mode.git")
> + (commit "8ef7127da214cb7fd4b47fc943462f2a8bfb8f85")))
Is there a reason to use 'git-fetch'? I think a usual 'url-fetch' is
fine as there is:
<https://github.com/clojure-emacs/clojure-mode/archive/5.3.0.tar.gz>.
> + (file-name (string-append name "-" version "-checkout"))
> + (sha256
> + (base32
> + "1x7nl5wzcah9hnlj5jfd3y5604w60zcqcw1nn6vw335c2vzzissj"))))
> + (build-system emacs-build-system)
> + (home-page "http://github.com/clojure-emacs/clojure-mode")
> + (synopsis "Major mode for Clojure code")
> + (description
> + "Provides font-lock, indentation, navigation and basic refactoring for
> the
We use full sentences for descriptions, like this: "This emacs package
provides ..."
> +Clojure programming language (http://clojure.org).
Since we use texinfo to format descriptions, it is better to write:
@uref{http://clojure.org, Clojure programming language}
> +
> +Using clojure-mode with paredit or smartparens is highly recommended.
I think this description is too verbose. I would remove all the text
below.
> +
> +Here are some example configurations:
> +
> + ;; require or autoload paredit-mode
> + (add-hook 'clojure-mode-hook #'paredit-mode)
> +
> + ;; require or autoload smartparens
> + (add-hook 'clojure-mode-hook #'smartparens-strict-mode)
> +
> +See inf-clojure (http://github.com/clojure-emacs/inf-clojure) for
> +basic interaction with Clojure subprocesses.
> +
> +See CIDER (http://github.com/clojure-emacs/cider) for
> +better interaction with subprocesses via nREPL.
> +")
> + (license license:gpl3+)))
--
Alex