guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add nlopt.


From: Roel Janssen
Subject: Re: [PATCH] gnu: Add nlopt.
Date: Tue, 03 May 2016 22:17:29 +0200
User-agent: mu4e 0.9.17; emacs 25.1.50.3

Ludovic Courtès writes:

> Roel Janssen <address@hidden> skribis:
>
>> I added your magic for Guile.  Here is the patch:
>>
>>>From 6221baadea331cff7e8ab6b9ea1b3bb7737b227f Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <address@hidden>
>> Date: Tue, 3 May 2016 14:30:25 +0200
>> Subject: [PATCH] gnu: Add nlopt.
>>
>> * gnu/packages/maths.scm (nlopt): New variable.
>
> Pushed with minor cosmetic changes, notably:
>
>> +    (source (origin
>> +      (method url-fetch)
>> +      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-";
>> +                          version ".tar.gz"))
>> +      (sha256
>> +       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
>
> “(method” should be indented below the “r” of “origin” (I think this
> pattern also appears in the R patches you recently submitted.)
>
> Thank you!

I've been submitting most packages this way.  Should I align (method
...) to the r in origin for all packages in the future?

Thank you!

Kind regards,
Roel Janssen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]