[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/10] gnu: ncurses: support mingw.
From: |
Jan Nieuwenhuizen |
Subject: |
Re: [PATCH 07/10] gnu: ncurses: support mingw. |
Date: |
Mon, 02 May 2016 20:41:31 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Andy Wingo writes:
> On Fri 29 Apr 2016 17:12, Jan Nieuwenhuizen <address@hidden> writes:
>
>> @@ -36,6 +39,7 @@
>> #:allow-other-keys)
>> (let ((out (assoc-ref outputs "out"))
>> (doc (assoc-ref outputs "doc")))
>> + (format #t "configure flags: ~s~%" configure-flags)
>> (zero? (apply system* "./configure"
>> (string-append "SHELL=" (which "sh"))
>> (string-append "--build=" build)
>
> Please remove :)
Hmm. Yes. I should maybe at least have put this in the commit
message?
It started out as a debug message...it confused me that the log file did
not mention my extra configure flags until I found
guix/build/gnu-build-system.scm (configure):
(format #t "source directory: ~s (relative from build: ~s)~%"
abs-srcdir srcdir)
(if out-of-source?
(begin
(mkdir "../build")
(chdir "../build")))
(format #t "build directory: ~s~%" (getcwd))
(format #t "configure flags: ~s~%" flags)
and I thought that at least printing the configure flags in ncurses'
custom configure stage would be nice. WDYT?
> Otherwise LGTM.
Otherwise I'd gladly remove it.
Greetings,
Jan
--
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | AvatarĀ® http://AvatarAcademy.nl