guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add Red Eclipse.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add Red Eclipse.
Date: Wed, 27 Apr 2016 14:14:37 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Alex Kost <address@hidden> skribis:


[...]

>> +         ;; Create origin records for the many separate data packages.
>> +         ,@(map (match-lambda
>> +                  ((name hash)
>> +                   (list name
>> +                         (origin
>> +                           (method url-fetch)
>> +                           (uri (string-append 
>> "https://github.com/red-eclipse/";
>> +                                               name "/archive/v" version 
>> ".tar.gz"))
>> +                           (sha256 (base32 hash))
>> +                           (file-name (string-append name "-" version 
>> ".tar.gz"))))))
>> +                data-sources)))
>
>
> I'm afraid this is not reliable.  I mean that all these data sources
> have the same "v1.5.3" tags.  I doubt that once there will be a new
> release of the base repository, they also will tag all the data repos to
> the new version.
>
> I think it's OK to do it like this for now, but if the mentioned problem
> will happen after the next release, we'll have to change this method
> (probably by making private "red-eclipse-<NAME>" packages for all data
> NAMEs).

Yeah I think it’s OK.  We can always adjust it when a new release comes
out.

>> +       "Red Eclipse is an open-source arena shooter, created from the Cube2

s/open-source//

>> +      ;; License information available in detail at the following link:
>> +      ;; http://redeclipse.net/wiki/License
>> +      (license (list license:expat
>> +                     license:zlib
>> +                     license:cc-by-sa3.0
>> +                     license:cc-by3.0
>> +                     license:cc0)))))

Would be worth mentioning that it’s a combination of all these licenses,
IIUC.

Looks like we’re there modulo this and the minor indentation issue?

Would you like to apply it with these changes, Alex?

Thank you all!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]