[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8.
From: |
Ben Woodcroft |
Subject: |
Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8. |
Date: |
Mon, 25 Apr 2016 09:45:37 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 25/04/16 03:04, Efraim Flashner wrote:
On Sun, Apr 24, 2016 at 11:06:17PM +1000, Ben Woodcroft wrote:
[..]
+ ;; 'setup.py test' does not run tests
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (setenv "PYTHONPATH"
+ (string-append
+ (getenv "PYTHONPATH")
+ ":"
+ out
+ "/lib/python"
some of the previous lines should be combined into one line
I think this is a matter of style, but I've amended it to below, which I
assume is OK - I have no strong opinions.
+ (setenv
+ "PYTHONPATH"
+ (string-append (getenv "PYTHONPATH")":" out "/lib/python"
+ (string-take (string-take-right
+ (assoc-ref inputs "python") 5) 3)
+ "/site-packages"))
[..]
+ (propagated-inputs
+ `(("python-pytest-cache", python-pytest-cache)
+ ("python-pytest" ,python-pytest)
+ ("python-pep8" ,python-pep8)))
Are you sure all of these need to be propagated?
That's what the install_requires in setup.py is telling me.
[..]
Thanks,
ben
- [PATCH 06/10] gnu: Add python-cachecontrol., (continued)
- [PATCH 06/10] gnu: Add python-cachecontrol., Ben Woodcroft, 2016/04/21
- [PATCH 2/2] gnu: Add python-scikit-bio., Ben Woodcroft, 2016/04/24
- [PATCH v2] Add python-scikit-bio., Ben Woodcroft, 2016/04/24
- [PATCH v2 01/10] gnu: Add python2-pytest-cache., Ben Woodcroft, 2016/04/24
- [PATCH v2 02/10] gnu: Add python-bz2file., Ben Woodcroft, 2016/04/24
- [PATCH v2 03/10] gnu: Add python-pytest-pep8., Ben Woodcroft, 2016/04/24
- Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8., Efraim Flashner, 2016/04/24
- Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8., Ben Woodcroft, 2016/04/24
- Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8.,
Ben Woodcroft <=
- Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8., Ricardo Wurmus, 2016/04/25
- Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8., Ben Woodcroft, 2016/04/25
- Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8., Leo Famulari, 2016/04/25
- proper Python inputs (was: gnu: Add python-pytest-pep8.), Hartmut Goebel, 2016/04/25
- Re: proper Python inputs (was: gnu: Add python-pytest-pep8.), Ricardo Wurmus, 2016/04/26
[PATCH v2 04/10] gnu: Add python-pytest-flakes., Ben Woodcroft, 2016/04/24
[PATCH v2 05/10] gnu: Add python-future., Ben Woodcroft, 2016/04/24
[PATCH v2 06/10] gnu: Add python-cachecontrol., Ben Woodcroft, 2016/04/24