[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add vcflib.
From: |
Roel Janssen |
Subject: |
Re: [PATCH] Add vcflib. |
Date: |
Fri, 22 Apr 2016 10:04:52 +0200 |
User-agent: |
mu4e 0.9.17; emacs 25.1.50.1 |
0001-gnu-Add-filevercmp.patch
Description: Text Data
Ricardo Wurmus writes:
> Roel Janssen <address@hidden> writes:
>
>> From f0cb8c476e902e3351988f7c278b3682837c8cce Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <address@hidden>
>> Date: Tue, 22 Mar 2016 15:47:06 +0100
>> Subject: [PATCH 5/8] gnu: Add filevercmp.
>
>> * gnu/packages/bioinformatics.scm (filevercmp): New variable.
>> ---
>> gnu/packages/bioinformatics.scm | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>
>> diff --git a/gnu/packages/bioinformatics.scm
>> b/gnu/packages/bioinformatics.scm
>> index 0abccbc..261660f 100644
>> --- a/gnu/packages/bioinformatics.scm
>> +++ b/gnu/packages/bioinformatics.scm
>> @@ -4923,3 +4923,31 @@ combinatorial configurations.\" G Ehrlich - Journal
>> of the ACM (JACM),
>> (synopsis "Program for managing SOM (Self-Organizing Maps) neural
>> networks")
>> (description "Program for managing SOM (Self-Organizing Maps) neural
>> networks.")
>> (license license:gpl3))))
>> +
>> +(define-public filevercmp
>> + (let ((commit "1a9b779b93d0b244040274794d402106907b71b7"))
>> + (package
>> + (name "filevercmp")
>> + (version (string-append "0-1." (string-take commit 7)))
>> + (source (origin
>> + (method url-fetch)
>> + (uri (string-append "https://github.com/ekg/filevercmp/archive/"
>> + commit ".tar.gz"))
>> + (file-name "filevercmp-src.tar.gz")
>
> Is this on purpose? Or should we use “(string-append name "-" version
> ".tar.gz")” instead?
This is on purpose. There is no released version. Therefore I gave it
"version" 0, with a "-1" suffix for Guix, and the first seven characters
of commit hash.
The download link includes the full commit hash.
>> + (sha256
>> + (base32 "0yp5jswf5j2pqc6517x277s4s6h1ss99v57kxw9gy0jkfl3yh450"))))
>> + (build-system gnu-build-system)
>> + (arguments
>> + `(#:tests? #f ; There are no tests to run.
>> + #:phases
>> + (modify-phases %standard-phases
>> + (delete 'configure) ; There is no configure phase.
>> + (replace 'install
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
>> + (install-file "filevercmp" bin)))))))
>> + (home-page "https://github.com/ekg/filevercmp")
>> + (synopsis "Program to compare version strings")
>> + (description "A program to compare version strings. It intends to be
>> a
>> +replacement for strverscmp.")
>
> Please turn the first sentence fragment into a full sentence.
Done.
- Re: [PATCH] Add vcflib., (continued)
Re: [PATCH] Add vcflib., Ricardo Wurmus, 2016/04/20
Re: [PATCH] Add vcflib., Ricardo Wurmus, 2016/04/20
Re: [PATCH] Add vcflib., Ricardo Wurmus, 2016/04/20
Re: [PATCH] Add vcflib., Ricardo Wurmus, 2016/04/20
- Re: [PATCH] Add vcflib.,
Roel Janssen <=
Re: [PATCH] Add vcflib., Ricardo Wurmus, 2016/04/20
Re: [PATCH] Add vcflib., Ricardo Wurmus, 2016/04/20
Re: [PATCH] Add vcflib., Ricardo Wurmus, 2016/04/20