[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] gnu: Add avr-binutils.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 1/5] gnu: Add avr-binutils. |
Date: |
Tue, 19 Apr 2016 16:55:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Manolis Ragkousis <address@hidden> skribis:
> On 04/14/16 20:04, Ludovic Courtès wrote:
>
>> AFAICS --target=avr is redundant:
>>
>> --8<---------------cut here---------------start------------->8---
>> $ git describe
>> v0.10.0-204-ga2d0e20
>> $ wget -q -O - $(./pre-inst-env guix build --log-file -e '((@ (gnu packages
>> cross-base) cross-binutils) "avr")') |grep -e --target
>> configure flags:
>> ("CONFIG_SHELL=/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42/bin/bash"
>> "SHELL=/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42/bin/bash"
>> "--prefix=/gnu/store/gqmq8gis9igpg4xy6022mvq8qpvp7kk4-binutils-cross-avr-2.25.1"
>> "--enable-fast-install" "--build=x86_64-unknown-linux-gnu" "--target=avr"
>> "--with-sysroot=/" "LDFLAGS=-static-libgcc"
>> "--with-lib-path=/no-ld-lib-path" "--disable-werror"
>> "--enable-install-libbfd" "--enable-deterministic-archives")
>> --8<---------------cut here---------------end--------------->8---
>>
>> … and --disable-nls is orthogonal and probably unnecessary.
>>
>> Can we skip this patch? :-)
>
> We added --disable-nls mostly because it was suggested from the avr-libc
> manual to be passed to binutils and gcc.
> <http://www.nongnu.org/avr-libc/user-manual/install_tools.html>
>
> David can you build the toolchain without it and see if it works?
It surely does. :-)
> And I would really prefer if we had a way to explicitly install
> avr-binutils. This way it will be more clear to someone only wanting to
> install this specific package.
>
> We could keep something like this
>
> (define-public avr-binutils
> (package
> (inherit (cross-binutils "avr"))
> (name "avr-binutils")))
I see. In that case, that’s a fine thing to do!
Maybe (define-public avr-binutils (cross-binutils "avr")) is enough
though? Or is its name too wordy?
Thanks,
Ludo’.
[PATCH 2/5] gnu: Add avr-gcc., David Thompson, 2016/04/14
[PATCH 4/5] gnu: Add avr-toolchain., David Thompson, 2016/04/14