Re: [PATCH] linux: alsa: update to 1.1.1

[Leo Famulari]

On Sat, Apr 16, 2016 at 08:51:36PM +0200, Danny Milosavljevic wrote:
> Hi,
> 
> this updates ALSA to 1.1.1.

Thanks for paying attention to upstream updates :)

> I removed alsa-lib-mips-atomic-fix.patch since I don't have MIPS and thus 
> can't test it. So could someone please check it and re-add?

Did you see anything in the upstream changelogs or commit history that
suggests we don't need this patch anymore? Can you take a look?

> I also added alsa-plugins. It contains shared objects to be loaded in 
> asoundrc or user asoundrc. For example it contains a pulseaudio module and a 
> downmixing module. asoundrc can be configured to provide a normal alsa device 
> and then redirect the output, like this:

Can you split that into a separate patch? We like to separate logically
different changes into individual commits.

> 
> pcm.pulse {
>     type pulse
> }
> 
> ctl.pulse {
>     type pulse
> }
> 
> pcm.default pulse
> ctl.default pulse
> 
> While testing it I noticed that the checksums of the same 1.1.1 files changed 
> multiple times. Does anyone know whether ALSA replaced the release?

And thank you for showing us how to test / use the changes. This is
*really* helpful when reviewing patches on subjects I'm not very
familiar with.

> * update ALSA to 1.1.1

Okay. This might have to go into core-updates, because many packages
will have to rebuilt [0].

> -             (patches (list (search-patch 
> "alsa-lib-mips-atomic-fix.patch")))))
> +               "0sa24fy3qf3jg63xxvfb7j8halj1qmdbcak2lyfx8bpd8hqnriwa"))
> +             ;(patches (list (search-patch 
> "alsa-lib-mips-atomic-fix.patch")))
> +))

If we get rid of the patch, we can just remove the lines of code from
the package definition. No need to comment it out :) Also, we would want
to delete the patch file itself, and remove the reference from
gnu-system.am (dist_patch_DATA).

> +(define-public alsa-plugins
> +  (package
> +    (name "alsa-plugins")
> +    (version "1.1.1")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "ftp://ftp.alsa-project.org/pub/plugins/alsa-plugins-";
> +                   version ".tar.bz2"))
> +             (sha256
> +              (base32
> +               "1w81z5jlwqhd1l2m7qrq69lc4k9dnrg1wn52jsl2hrf3hbhd394f"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://www.alsa-project.org/";)
> +    (synopsis "The Advanced Linux Sound Architecture plugins")
> +    (description
> +     "The Advanced Linux Sound Architecture (ALSA) provides audio and
> +MIDI functionality to the Linux-based operating system.")
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("alsa-lib" ,alsa-lib)))
> +    (license (list license:lgpl2.1+ license:gpl2+))))

Okay as a separate patch with a brief comment explaining why there are
multiple licenses.

>  (define-public alsa-utils
>    (package
>      (name "alsa-utils")
> -    (version "1.1.0")
> +    (version "1.1.1")

Can you see if alsa-lib and alsa-utils must be updated in the same
commit? That is, will they break if they are not the same version? If
so, we will do them in the same commit. Else, I prefer to update them in
separate commits.

I see that commit 992b527d5 updated alsa-utils to 1.1.0, but alsa-lib
was still on 1.0.27.1.

Can you submit a revised patch series?

[0]
$ guix refresh -l alsa-lib
Building the following 170 packages would ensure 286 dependent packages
are rebuilt: i3status-2.9 qemu-minimal-2.5.0 ripperx-2.8.0 abcde-2.7.1
mpc123-0.2.4 orpheus-1.6 giac-xcas-1.2.2-37 xfce-4.12.0 wxmaxima-15.04.0
wesnoth-1.12.4 sdl-gfx-2.0.24 qemu-2.5.0 raincat-1.1.1.3 agg-2.5
pingus-0.7.6 fizmo-0.7.9 pinball-0.3.1 extremetuxracer-0.6.0
gnujump-1.0.8 desmume-0.9.11 gzochi-0.9 sfxr-1.2.1 sdl2-mixer-2.0.1
sdl2-ttf-2.0.14 sdl2-image-2.0.1 mupen64plus-video-arachnoid-2.0.0
mupen64plus-rsp-z64-2.0.0 mupen64plus-video-z64-2.0.0 nestopia-ue-1.46.2
mupen64plus-ui-console-2.5 frescobaldi-2.18.2 keepassx-2.0.2
brdf-explorer-17 kccmp-0.3 scribus-1.5.1 python-pyqt-5.5 pumpa-0.9.2
polkit-qt-1-0.112.0 owncloud-client-2.1.1 lxqt-session-0.9.0
lxqt-common-0.9.1 quassel-0.12.3 gpsbabel-1.5.2 tiled-0.15.1
bitcoin-core-0.11.2 fritzing-0.9.2b librecad-2.0.9 calibre-2.51.0
gtk-vnc-0.5.4 xmp-4.0.10 cursynth-1.5 pavucontrol-3.0 hexchat-2.12.0
claws-mail-3.13.2 lablgtk-2.18.3 gsegrafix-1.0.6 gnome-screenshot-3.18.0
aisleriot-3.18.2 gnubg-1.02 libcanberra-gtk2-0.30
ruby-atoulme-antwrap-0.7.5 sra-tools-2.5.7 htsjdk-1.129 icedtea-1.13.10
libzapojit-0.0.3 devhelp-3.18.1 gnucash-2.6.12 libreoffice-5.0.5.2
python2-gst-1.8.0 python-gst-1.8.0 gst-plugins-ugly-1.8.0 abiword-3.0.1
byzanz-0.2-1.f7af3a5 tuxguitar-1.2 conkeror-1.0pre1.20150730
emulation-station-2.0.1 dosbox-0.74.svn3947 evas-generic-loaders-1.17.0
terminology-0.9.1 python2-efl-1.16.0 rage-0.1.4 python-efl-1.16.0
enlightenment-0.20.6 hop-2.4.0 patches-0.0.26d7dbc
notmuch-addrlookup-c-7 emacs-auctex-11.88.6
emacs-mit-scheme-doc-20140203 emacs-slime-2.15 emacs-constants-2.2
emacs-butler-0.2.4 emacs-debbugs-0.9 emacs-undo-tree-0.6.4
emacs-typo-1.1 emacs-god-mode-20151005.925.1-6cf0807b6
emacs-scheme-complete-20151223.9b5cf224
emacs-ob-ipython-20150704.8807064693 vc-dwim-1.7 scmutils-20140302
proof-general-4.2 mu-0.9.13 idutils-4.6 paredit-24 emacs-popup-0.5.3
emacs-w3m-1.4.538+0.20141022 emacs-wget-0.5.0 emacs-flycheck-0.23
haskell-mode-13.14.2 bbdb-3.1.2 git-modes-1.2.1 emacs-pdf-tools-0.70
magit-svn-2.1.1 guix-0.10.0-0.7611 guix-0.10.0 emms-4.0
emacs-mmm-mode-0.5.4 recutils-1.7 cflow-1.4 guile-emacs-20150512.41120e0
emacs-no-x-toolkit-24.5 wine-1.9.4 emotion-generic-players-1.17.0
mplayer-1.3.0 pianobar-2015.11.22 mpd-0.19.14 kodi-16.0 gst-libav-1.8.0
guile-gnunet-0.0.383eac2 gnunet-gtk-0.10.1 minetest-0.4.13
retroarch-1.3.1 mars-0.7.5.1.c855d04409 love-0.10.0 jack2-1.9.10
avidemux-2.6.10 obs-0.13.2 non-sequencer-1.9.5-1d9bd576
milkytracker-0.90.86 cmus-2.7.1 zynaddsubfx-2.5.3 qtractor-0.7.5
setbfree-0.8.0 bristol-0.60.11 yoshimi-1.3.8.2 gtklick-0.6.4 pd-0.45.4
rhythmbox-3.2.1 gnome-3.18.3 shotwell-0.22.0 gamine-1.4 blender-2.76b
xjackfreak-1.0 jalv-1.4.6 hydrogen-0.9.6.1 vmpk-0.6.2a
gst-plugins-bad-1.6.3 qsynth-0.4.1 azr3-1.2.3 alsa-modular-synth-2.1.2
solfege-3.22.2 powertabeditor-2.0.0-alpha8 guitarix-0.34.0 calf-0.0.60
ardour-4.7 patchage-1.0.0 mpv-0.16.0 zita-alsa-pcmi-0.2.0
rakarrack-0.6.1 synfigstudio-1.0.2 audacity-2.1.0